Add SPI for delegating row expression optimizer #24144
Open
+1,535
−335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdcmeehan
requested review from
shrinidhijoshi,
a team,
jaystarshot,
feilong-liu,
elharo and
ClarenceThreepwood
as code owners
prestodb-ci
requested review from
a team,
sh-shamsan and
pdabre12
and removed request for
a team
pdabre12
reviewed
Nov 25, 2024
| @@ -704,6 +706,11 @@ public ShutdownAction getShutdownAction() | |||
| return shutdownAction; | |||
| } | |||
|
|
|||
| public ExpressionOptimizerManager getExpressionManager() | |||
| { | |||
| return injector.getInstance(ExpressionOptimizerManager.class); | |||
There was a problem hiding this comment.
Can we make this a member variable?
| @Inject | ||
| public ExpressionOptimizerManager(InternalNodeManager nodeManager, FunctionAndTypeManager functionAndTypeManager, NodeInfo nodeInfo) | ||
| { | ||
| requireNonNull(nodeManager, "nodeManager is null"); |
There was a problem hiding this comment.
Is there a specific need for the nodeManager to be of type InternalNodeManager. It seems like it gets used for pluginNodeManager, why not inject an instance of pluginNodeManager instead?
tdcmeehan
force-pushed
the
expr-spi-init
branch
7 times, most recently
from
78485b3
to
af9f214
Compare
The runtime should consolidate to the `ExpressionOptimizerProvider` factory so that it can be customized without significant refactoring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of RFC-0006, we need to support out of process expression evaluation. Add support for pluggable expression optimization and planner support to utilize the new SPI.
Motivation and Context
RFC-0006
Impact
No impact by default as the old in-memory evaluation is the default.
Test Plan
Tests have been added.
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.
If release note is NOT required, use: