Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop experimental.table-writer-merge-operator-enabled config #24145

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

arhimondr
Copy link
Member

@arhimondr arhimondr commented Nov 25, 2024

Description

As per title

Motivation and Context

Enabled by default for a very long time. When table_writer_merge_operator_enabled=false partitioned table writes are likely broken.

Impact

table_writer_merge_operator_enabled session property will no longer be available

Test Plan

CI

Contributor checklist

  • Please make sure your submission complies with our development, formatting, commit message, and attribution guidelines.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* Remove the ``experimental.table-writer-merge-operator-enabled` config property and the ``table_writer_merge_operator_enabled`` session property :pr:`12345`

Enabled by default for a very long time
@arhimondr
Copy link
Member Author

Thank you for the review @yingsu00

@arhimondr arhimondr merged commit b7501f9 into prestodb:master Nov 26, 2024
61 checks passed
@arhimondr arhimondr deleted the drop-table-writer-merge-flag branch November 26, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from:Meta PR from Meta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants