-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Expose QueryType & Catalog in Session API #24972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
presto-spi/src/main/java/com/facebook/presto/spi/ConnectorSession.java
Outdated
Show resolved
Hide resolved
presto-spi/src/main/java/com/facebook/presto/spi/ConnectorSession.java
Outdated
Show resolved
Hide resolved
presto-main-base/src/main/java/com/facebook/presto/testing/TestingConnectorSession.java
Outdated
Show resolved
Hide resolved
Thanks for the release note! Suggestion to follow the Order of changes in the Release Notes Guidelines:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
presto-main-base/src/main/java/com/facebook/presto/FullConnectorSession.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks fine, but can we explain more why this change is needed. It is an SPI change after all. We should try to meticulously document the reason for SPI changes being made
Description
Exposes catalog & queryType in the Session API
Motivation and Context
To support connector upgrade
Impact
Catalog & QueryType can be retrieved from session
Test Plan
UTs
Contributor checklist
Release Notes