Skip to content

Expose QueryType & Catalog in Session API #24972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

infvg
Copy link
Contributor

@infvg infvg commented Apr 24, 2025

Description

Exposes catalog & queryType in the Session API

Motivation and Context

To support connector upgrade

Impact

Catalog & QueryType can be retrieved from session

Test Plan

UTs

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

== RELEASE NOTES ==

SPI Changes
* Expose query type & catalog in Session API

@infvg infvg requested a review from a team as a code owner April 24, 2025 10:46
@infvg infvg requested a review from ZacBlanco April 24, 2025 10:46
@prestodb-ci prestodb-ci added the from:IBM PR from IBM label Apr 24, 2025
@prestodb-ci prestodb-ci requested review from a team, jp-sivaprasad and auden-woolfson and removed request for a team April 24, 2025 10:46
@steveburnett
Copy link
Contributor

Thanks for the release note! Suggestion to follow the Order of changes in the Release Notes Guidelines:

== RELEASE NOTES ==

SPI Changes
* Add expose query type & catalog in Session API.

Copy link
Contributor

@auden-woolfson auden-woolfson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Contributor

@ZacBlanco ZacBlanco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine, but can we explain more why this change is needed. It is an SPI change after all. We should try to meticulously document the reason for SPI changes being made

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
from:IBM PR from IBM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants