Skip to content

[WIP] Improve finer granularity of error classification in presto-native #24980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

anlowee
Copy link

@anlowee anlowee commented Apr 24, 2025

Description

Potential implementation for #24959

Motivation and Context

Impact

For the exceptions thrown within checkStatus function of GcsFileSystem.cpp it can be classified to the corresponding HIVE errors like HIVE_FILE_NOT_FOUND and HIVE_CANNOT_OPEN_SPLIT, which are EXTERNAL error. Currently there is no classification for them so they are just GENERIC_INTERNAL_ERROR which is an INTERNAL_ERROR.

Test Plan

Added a unit test.

Contributor checklist

  • Please make sure your submission complies with our contributing guide, in particular code style and commit standards.
  • PR description addresses the issue accurately and concisely. If the change is non-trivial, a GitHub Issue is referenced.
  • Documented new properties (with its default value), SQL syntax, functions, or other functionality.
  • If release notes are required, they follow the release notes guidelines.
  • Adequate tests were added if applicable.
  • CI passed.

Release Notes

Please follow release notes guidelines and fill in the release notes below.

== RELEASE NOTES ==

General Changes
* ... 
* ... 

Hive Connector Changes
* ... 
* ... 

If release note is NOT required, use:

== NO RELEASE NOTE ==

Copy link

linux-foundation-easycla bot commented Apr 24, 2025

CLA Signed


The committers listed above are authorized under a signed CLA.

@anlowee anlowee force-pushed the xwei/presto-24959 branch from 8383090 to 5f6e673 Compare April 24, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant