Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 0.291 docs #290

Merged
merged 3 commits into from
Feb 11, 2025
Merged

Add 0.291 docs #290

merged 3 commits into from
Feb 11, 2025

Conversation

wanglinsong
Copy link
Member

No description provided.

@ZacBlanco
Copy link
Contributor

@wanglinsong can you apply this patch to the PR
docs.patch

@ZacBlanco
Copy link
Contributor

ZacBlanco commented Feb 11, 2025 •
edited
Loading

Also, I noticed the CI failed. I think this may be due to GH actions recently updating the default nodejs version in their runners. We have the node version set explicitly in the actions/setup-node step

The action may need an update..

steveburnett
steveburnett approved these changes Feb 11, 2025
View reviewed changes
Copy link

@steveburnett steveburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (docs)

Pull branch and reviewed the HTML in the branch, starting at
file:///Users/steveburnett/Documents/GitHub/prestodb.github.io/website/static/docs/0.291/index.html

The 0.291 release notes are present, the headers say 0.291. Random sampling throughout the site showed me no problems with the docs in /website/static/docs/0.291/.

@steveburnett
Copy link

If you want me to pull and review again after @ZacBlanco's docs-patch is applied, just ask and I will look again.

yhwang and others added 2 commits February 11, 2025 13:07
@yhwang
patch css and siteConfig.js
b242943 
Signed-off-by: Yihong Wang <[email protected]>
@wanglinsong
Merge pull request #1 from yhwang/patch-0.291
79ecdaa 
patch css and siteConfig.js
ZacBlanco
ZacBlanco approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@ZacBlanco ZacBlanco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yhwang , the PR looks good now

@alileclerc alileclerc merged commit f72b3e1 into prestodb:source Feb 11, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZacBlanco ZacBlanco ZacBlanco approved these changes

@steveburnett steveburnett steveburnett approved these changes

@alileclerc alileclerc alileclerc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wanglinsong @ZacBlanco @steveburnett @alileclerc @yhwang