Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update deployment target to 10.13 #2

Merged
merged 7 commits into from
Nov 15, 2022
Merged

Update deployment target to 10.13 #2

merged 7 commits into from
Nov 15, 2022

Conversation

peterkutasi
Copy link

@peterkutasi peterkutasi commented Nov 15, 2022 •
edited
Loading

VMyroniuk
VMyroniuk reviewed Nov 15, 2022
View reviewed changes
ReactiveObjC/extobjc/EXTRuntimeExtensions.m Outdated
@@ -62,7 +62,7 @@

if (!next) {
fprintf(stderr, "ERROR: Could not read class name in attribute string \"%s\" for property %s\n", attrString, property_getName(property));
return NULL;
goto errorOut;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please fix the indentation?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure but it seems like a github diff issue. If I sync the project the indentation looks fine and no matter what I do I don't see diff compared to the origin. 🤔

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, it seems I managed to fix it.

@peterkutasi peterkutasi merged commit e57fd26 into no-generics Nov 15, 2022
@peterkutasi peterkutasi deleted the update-deployment-target branch November 15, 2022 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VMyroniuk VMyroniuk VMyroniuk left review comments

@peter-kotroczo-prezi peter-kotroczo-prezi peter-kotroczo-prezi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peterkutasi @peter-kotroczo-prezi @VMyroniuk