Merge pull request #4 from prezly/fix/exclude-empty-rows-from-the-cal…

…culated-partition Exclude empty groups from the calculated partitioning
prezly · Jun 3, 2022 · 582da71 · 582da71
2 parents ead7004 + bc16af2
commit 582da71
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/linearPartition.test.ts b/src/linearPartition.test.ts
@@ -71,6 +71,13 @@ describe('linearPartition', () => {
                 [74, 77, 133, 64],
             ],
         },
+        {
+            input: {
+                elements: [150, 66.65, 66.65, 150, 100, 150, 66.65],
+                maxRanges: 11,
+            },
+            output: [[150], [66.65, 66.65], [150], [100], [150], [66.65]],
+        },
     ];
 
     tests.forEach(({ input: { elements, maxRanges }, output }) => {

diff --git a/src/linearPartition.ts b/src/linearPartition.ts
@@ -65,7 +65,8 @@ const reconstructPartitioning = (S: number[], D: number[][], n: number, k: numbe
     }
 
     // Fix order as we reconstructed the partitioning from end to start
-    return partition.reverse();
+    // Ignoring possibly empty rows, appearing when there are no delimiters for the given `j` index.
+    return partition.reverse().filter((row) => row.length > 0);
 };
 
 export function linearPartition(elements: number[], maxRanges: number): number[][] {