Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat : cicd swagger 설정 #26

Merged
merged 15 commits into from
Nov 29, 2024
Merged

Conversation

kang-ye-jin
Copy link
Collaborator

@kang-ye-jin kang-ye-jin commented Nov 26, 2024

🔓closed #24

📌 과제 설명

  • cicd 구축
  • swagger 설정
  • 주석 처리한 컨트롤러 테스트 구현

👩‍💻 요구 사항과 구현 내용

  • 임시 배포 cicd를 구축했습니다.
  • swagger를 설정했습니다.
  • controller 테스트를 재작성했습니다.

✅ 피드백 반영사항

✋ PR 포인트 & 궁금한 점

  • 배포가 한 번에 잘 되면 너무 너무 좋겠지만, 이슈가 있다면 바로 수정하겠습니다.
  • develop 기준 존재하는 controller에는 임의로 swagger에 들어갈 Operation을 생성하였습니다. 수정할 부분이 있다면 이 브랜치에서 수정 부탁드립니다! 리뷰 승인해주시면 따로 수정 사항이 없는 걸로 간주하겠습니다 ☺️

@kang-ye-jin kang-ye-jin self-assigned this Nov 26, 2024
@kang-ye-jin kang-ye-jin linked an issue Nov 26, 2024 that may be closed by this pull request
- course
- vote
- wishPlace
Copy link
Collaborator

@youjungHwang youjungHwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

@@ -1,5 +1,5 @@
server:
port: 8090
port: 5000
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이 부분 왜 5000으로 수정하신 걸까요?🤗

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

배포 후 엘라스틱빈스톡에서 5000번 포트를 사용해서 변경하였습니다!

@ActiveProfiles("test")
@Transactional
@TestInstance(TestInstance.Lifecycle.PER_CLASS)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이건 어떤 용도의 어노테이션일까요?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WithUserDetails는 테스트 메서드가 실행되기 전에 SecurityContext를 초기화하기 때문에 생성한 회원을 찾지 못합니다. 그래서 초기화하기 전에 필요한 회원 객체를 생성하도록 순서를 보장하기 위해서 사용한 어노테이션입니다 😊

Copy link
Collaborator

@asklas asklas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Member 도메인과 SecurityConfig Conflict 발생하여 해결하였습니다

@kang-ye-jin kang-ye-jin merged commit ec8473f into develop Nov 29, 2024
@kang-ye-jin kang-ye-jin deleted the feat/#24-cicd-swagger-설정 branch November 29, 2024 03:04
@kang-ye-jin kang-ye-jin changed the title Feat: cicd swagger 설정 feat : cicd swagger 설정 Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore : cicd, swagger 설정
3 participants