Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#664] [독서 모임] 참여 중인 모임 UI 개선 #670

Merged
merged 6 commits into from
Aug 5, 2024
Merged

[#664] [독서 모임] 참여 중인 모임 UI 개선 #670

merged 6 commits into from
Aug 5, 2024

Conversation

gxxrxn
Copy link
Member

@gxxrxn gxxrxn commented Jul 29, 2024

구현 내용

  • 목록 리스트에 heading 요소를 추가했어요.
    • 내 모임, 전체 모임
  • 참여한 모임이 없는 경우, 모임 생성을 유도하는 배너를 노출해요.
    • 로그인을 한 경우에만 노출돼요.
  • 모임장인 경우, 참여 모임 목록 카드에 운영 뱃지가 노출되도록 수정했어요.
    • 이전에 제목에 노출되던 👑 이모지는 제거했어요.

스크린샷

참여한 모임이 없는 경우 배너 노출

스크린샷 2024-07-29 오후 8 13 25

참여한 모임이 있는 경우

스크린샷 2024-07-29 오후 8 18 03

Help

관련 이슈

@gxxrxn gxxrxn added 🐥 프론트 필수! ✨ feature New feature or request 🔥 v.1.0 New feature for releasing v.1.0 labels Jul 29, 2024
@gxxrxn gxxrxn requested a review from hanyugeon July 29, 2024 12:32
@gxxrxn gxxrxn self-assigned this Jul 29, 2024
@vercel Vercel
Copy link

vercel bot commented Jul 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dadok ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2024 0:37am

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 29, 2024 •
edited
Loading

🚀 Storybook: https://64aba10cd478ad51307a8997-qzpqzuijlv.chromatic.com/

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 29, 2024 •
edited
Loading

⚡️ Lighthouse Average Scores Across Reports:

Category Score
🔴 performance 64
🟢 accessibility 91
🟢 best practices 98
🟢 seo 100
🟢 pwa 100

⚡️ Average Details Across All Reports:

Category Score
🟢 first contentful paint 0.9s
🔴 largest contentful paint 13.1s
🔴 interactive 7.6s
🟠 total blocking time 300.1ms
🟢 cumulative layout shift 0.0

hanyugeon
hanyugeon approved these changes Jul 31, 2024
View reviewed changes
Copy link
Member

@hanyugeon hanyugeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

배너처럼 큰 컨탠츠의 색깔 디자인하기가 정말 어렵던데..
저희 프로덕트에 잘 어울리게 만들어주셨네요!!

고생하셨습니다 💯
남긴 코멘트는 편하게 봐주셔도 될 것 같아요~

src/components/bookGroup/DetailBookGroupCard.tsx Show resolved Hide resolved
src/components/bookGroup/SimpleBookGroupCard.tsx Show resolved Hide resolved
@gxxrxn gxxrxn merged commit 6609f5b into main Aug 5, 2024
4 checks passed
@gxxrxn gxxrxn deleted the feat/#664 branch August 5, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanyugeon hanyugeon hanyugeon approved these changes

Assignees

@gxxrxn gxxrxn

Labels
✨ feature New feature or request 🐥 프론트 필수! 🔥 v.1.0 New feature for releasing v.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[독서 모임] 참여 중인 모임 UI 개선
2 participants
@gxxrxn @hanyugeon