Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#684] [fix] Dropdown Menu를 BottomSheet로 수정 #686

Merged
merged 3 commits into from
Aug 18, 2024
Merged

[#684] [fix] Dropdown Menu를 BottomSheet로 수정 #686

merged 3 commits into from
Aug 18, 2024

Conversation

gxxrxn
Copy link
Member

@gxxrxn gxxrxn commented Aug 15, 2024

구현 내용

  • Dropdown menu를 모바일 뷰에 친화적인 BottomSheet 형태로 수정했어요.

스크린샷

스크린샷 2024-08-15 오후 7 43 28

관련 이슈

@gxxrxn gxxrxn added 🐥 프론트 필수! 🐛 fix Something isn't working 🔥 v.1.0 New feature for releasing v.1.0 labels Aug 15, 2024
@gxxrxn gxxrxn requested a review from hanyugeon August 15, 2024 10:44
@gxxrxn gxxrxn self-assigned this Aug 15, 2024
@vercel Vercel
Copy link

vercel bot commented Aug 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dadok ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 15, 2024 10:49am

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 15, 2024 •
edited
Loading

🚀 Storybook: https://64aba10cd478ad51307a8997-zwisutcurq.chromatic.com/

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 15, 2024 •
edited
Loading

⚡️ Lighthouse Average Scores Across Reports:

Category Score
🔴 performance 69
🟢 accessibility 91
🟢 best practices 98
🟢 seo 100
🟢 pwa 100

⚡️ Average Details Across All Reports:

Category Score
🟢 first contentful paint 0.8s
🔴 largest contentful paint 13.2s
🔴 interactive 8.1s
🟢 total blocking time 266.3ms
🟢 cumulative layout shift 0.0

hanyugeon
hanyugeon approved these changes Aug 18, 2024
View reviewed changes
Copy link
Member

@hanyugeon hanyugeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!!
저희 프로젝트가 바텀시트랑도 잘 어울리는 것 같아요 👍

@gxxrxn gxxrxn merged commit 8dc1df0 into main Aug 18, 2024
4 checks passed
@gxxrxn gxxrxn deleted the fix/#684 branch August 18, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hanyugeon hanyugeon hanyugeon approved these changes

Assignees

@gxxrxn gxxrxn

Labels
🐛 fix Something isn't working 🐥 프론트 필수! 🔥 v.1.0 New feature for releasing v.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[fix] Dropdown Menu를 BottomSheet로 수정
2 participants
@gxxrxn @hanyugeon