Bump opentelemetry_semantic_conventions from 0.2.0 to 1.27.0 #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
Bumps [opentelemetry_semantic_conventions](https://github.com/open-telemetry/opentelemetry-erlang) from 0.2.0 to 1.27.0. - [Release notes](https://github.com/open-telemetry/opentelemetry-erlang/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-erlang/blob/main/CHANGELOG.md) - [Commits](https://github.com/open-telemetry/opentelemetry-erlang/commits) --- updated-dependencies: - dependency-name: opentelemetry_semantic_conventions dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
MaeIsBad
previously approved these changes
Oct 10, 2024
lib/teleplug.ex
Outdated
| @@ -6,23 +6,34 @@ defmodule Teleplug do | |||
| alias Plug.Conn | |||
|
|
|||
| require Logger | |||
| require OpenTelemetry.SemanticConventions.Trace, as: Conventions | |||
| require OpenTelemetry.SemConv.ClientAttributes, as: ClientAttributes | |||
There was a problem hiding this comment.
Are we sure we need a require and not an alias here?
There was a problem hiding this comment.
Not really honestly, I don't know why they were implemented as require originally but I have a feeling they should be alias... let me change that
There was a problem hiding this comment.
I think Trace has some kind of magic inside of it. But i don't think this applies to the other SemConv modules
cottinisimone
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps opentelemetry_semantic_conventions from 0.2.0 to 1.27.0.
Release notes
Sourced from opentelemetry_semantic_conventions's releases.
... (truncated)
Changelog
Sourced from opentelemetry_semantic_conventions's changelog.
... (truncated)
Commits
You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)