Fix #211: Append System.lineSeparator() to last line #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blutorange
reviewed
Oct 1, 2024
| } | ||
|
|
||
| // write / append content into / to the new file | ||
| Files.asCharSink(outputFile, cset, FileWriteMode.APPEND).write(writer.toString()); | ||
| Files.asCharSink(outputFile, cset, FileWriteMode.APPEND).write(System.lineSeparator() + writer.toString()); |
There was a problem hiding this comment.
Looks all good to me 👍 Technically I suppose this adds two line terminators to JS files (?), but there's no problem with that. Regarding the type of line separator, both CSS and EcmaScript support both \n\r and \n, so that should also be ok.
A micro-optimization (probably not needed): Call write twice instead of concatenating System.lineSeparator() with writer.toString().
There was a problem hiding this comment.
good idea just refactored to make it cleaner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #211: Append System.lineSeparator() to last line