Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Password): add cursor pointer to ToggleMask icon #7132

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

xl495
Copy link
Contributor

@xl495 xl495 commented Jan 23, 2025

Add cursor pointer style to Password component's ToggleMask icon

Changes

  • Added cursor: pointer style to the ToggleMask icon in Password component to improve user interaction feedback

Motivation

When hovering over the ToggleMask icon, there was no visual indication that it was clickable. This small style enhancement improves the user experience by making it clear that the icon is interactive.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which improves existing functionality)

Copy link

vercel bot commented Jan 23, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Updated (UTC)
primevue ⬜️ Ignored (Inspect) Visit Preview Jan 23, 2025 6:00am
primevue-v3 ⬜️ Ignored (Inspect) Visit Preview Jan 23, 2025 6:00am

@mertsincan mertsincan linked an issue Jan 27, 2025 that may be closed by this pull request
@mertsincan mertsincan merged commit 4ae0519 into primefaces:master Jan 27, 2025
2 checks passed
@mertsincan
Copy link
Member

Thanks a lot for your contribution!

@mertsincan
Copy link
Member

Reverted. Ref: primefaces/primeng#17510

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add cursor pointer to ToggleMask icon on Password
2 participants