[#13] 토글 공통 컴포넌트 구현 #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
hanseulhee
approved these changes
May 13, 2024
Comment on lines
+1
to
+6
| import ToggleRoot from './ToggleRoot' | ||
| import ToggleThumb from './ToggleThumb' | ||
|
|
||
| const Toggle = () => { | ||
| return ( | ||
| <ToggleRoot> |
There was a problem hiding this comment.
👍🏻👍🏻👍🏻👍🏻 경로만 절대로 바꾸면 좋을 것 같아용 !!
03hoho03
requested changes
May 13, 2024
| @@ -0,0 +1,24 @@ | |||
| 'use client' | |||
|
|
|||
| import * as Switch from '@radix-ui/react-switch' | |||
There was a problem hiding this comment.
현재 radix 라이브러리를 전체를 가르키는 변수명을 [기능]Primitive 로 이름짓구 있습니다. SwitchPrimitive로 바꾸면 컨벤션을 유지 할 수 있을꺼같아요 !!
| height: 21px; | ||
| background-color: ${theme.color.white}; | ||
| border-radius: 9999px; | ||
| box-shadow: 0 2px 2px var(--black-a7); |
There was a problem hiding this comment.
현재 여기 있는 --black-a7 변수는 제대로 적용되고 있는걸까요??
There was a problem hiding this comment.
레퍼런스 하는 도중에 들억간거 같습니다. 수정하겠습니다 !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧑🏻💻 작업 내용
2024-05-13.6.17.55.mov
🚀 중요한 포인트
저희가 toggle이라고 생각했던 ui가 radix에는 switch로 나와있어 부득이하게 이름을 바꾸었습니다. 사용하실때 헷갈리지않고 사용하세요.!