Refactor angular directive syntax #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. add dedicated `meta.directive` scopes (like in VueJS syntax) 2. use angular expression syntax in directive values instead of plain JavaScript
This commit moves angular expressions for a more logical order of sections, starting with... 1. HTML injections 2. angular directives 3. angular declarations (let statement) 4. angular control flow statements 5. angular interpolation followed by... 6. angular expressions with all following contexts being part of expressions.
deathaxe
force-pushed
the
feat/component-directives
branch
from
1d178c3 to
18da096
Compare
|
👍👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors directive related contexts to
meta.directivethe same way as it is done for VueJS syntaxas,ofand other special keywords as well as pipe syntax etc.ngIfandngFordirectiveskeyword.controlto clearly distinguish them from "normal" bindings.It rearranges expression contexts and variables to get a top-down logical context/section order starting with customized HTML contexts as root of the tree.