Fix meta.embedded vs. meta.interpolation #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds `.expression` sub-scope name to distinguish embedded interpolation expressions from control flow statements.
This commit adds new `ng-string-interpolations` context, which in addition to `ng-string-interpolations` to clear `string` scope in quoted strings. This ensures interpolated expressions are 1. treated as normal source instead of applying special string rules 2. correctly highlighted avoiding unmatched tokens looking like strings. An inherited special purpose CSS syntax is added to support Mustache tags in inline styles.
This commit overrides HTML's default `style-css-content` to use CSS (for Ngx) syntax between `<style>` tags, enabling interpolation support. Note: Maybe not so relevant in templates, but in case someone wants to use it.
This commit scopes all control flow statements `meta.embedded.statement source.ngx.embedded.html`. to also apply proper `source.ngx` to angular expressions.
This commit scopes whole document `meta.template`. Various template syntaxes make use of it to be able to use simpler snippet or completion selectors across all supported languages (e.g.: CSS/JS/HTML).
deathaxe
force-pushed
the
fix/interpolations
branch
from
4bf8af9 to
3dcec66
Compare
|
👍 Can't find any problem in my relatively large projects. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR...
fixes #33
{{ ... }}interpolation in attribute values, quoted strings and CDATA content tags, including inline styles or code of possible<style>tags.{{ ... }}meta.embedded.expressionto distinguish from control flow statements.meta.embedded.statementto control flow statements such as@if,@for, etc.meta.template.ngxto align with Jinja2, Twig, Vue and others.Note: We could also scope
{{...}}meta.interpolationas those actually inject expression evaluation results into output text. However it is not easy in all template languages to make that distinction. Hence in favor of consistent scopingmeta.embedded.expressionis used. It also allows simpler snippet/completion selectors targeting both, statements and interpolation viameta.template.ngx meta.embedded. Jinja2, Twig, Svelte already use that schema as well.