Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pgbouncer docs #6346

Merged
merged 19 commits into from
Dec 4, 2024
Merged

Update pgbouncer docs #6346

merged 19 commits into from
Dec 4, 2024

Conversation

biw
Copy link
Contributor

@biw biw commented Oct 18, 2024

Due to prisma/prisma#21531, the currect docs are incorrect regarding setting up pgbouncer with prisma. This updates the docs to reflect the correct info.

@biw biw changed the title working on updating pgbouncer docs Update pgbouncer docs Oct 18, 2024
@JelteF
Copy link

JelteF commented Oct 18, 2024

LGTM

@gniting
Copy link
Contributor

gniting commented Nov 21, 2024

@jharrell is there an update on this in terms of getting it merged?

@ankur-arch
Copy link
Contributor

Hey @biw 👋 ,

Thanks for raising the PR! I left some suggestions and we can merge this in after those are resolved.

@ankur-arch
Copy link
Contributor

ankur-arch commented Dec 3, 2024

I imagine having docs for multiple versions/configurations of PgBouncer would add confusion for the vast majority of developers, but can edit it if you disagree.

That's a fair point. However, users using older versions of PgBouncer will run into a different confusion 😄 . To simplify, I think we can also add a note asking users to use the latest version of PgBouncer.

A bigger question for you and the dev team at prisma is:
"Should ?pgbouncer=true be deprecated given that @JelteF, one of the maintainers of PgBouncer recommends not using it?"

That's a very good question @biw and has been brought to the attention of our team. I'll follow-up on our discussions here 👍 .

Sidenote: this PR will close #5708.

@jharrell jharrell merged commit 2f42f99 into prisma:main Dec 4, 2024
2 of 6 checks passed
@jharrell
Copy link
Member

jharrell commented Dec 4, 2024

Thanks for your patience @biw and @JelteF ! Excited to get this merged 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants