-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade docs to v6 #6445
base: main
Are you sure you want to change the base?
upgrade docs to v6 #6445
Conversation
Dangerous URL checkNo absolute URLs to prisma.io/docs found. |
Redirect checkThis PR probably requires the following redirects to be added to static/_redirects:
|
@@ -18,7 +18,7 @@ If you want to use Prisma ORM with your own PostgreSQL, MySQL, MongoDB or any ot | |||
|
|||
## Prerequisites | |||
|
|||
You need Node.js v16.13.0 or higher for this guide (learn more about [system requirements](/orm/reference/system-requirements)). | |||
You need Node.js 18.18.0 / 20.9.0 / 22.11.0 or higher for this guide (learn more about [system requirements](/orm/reference/system-requirements)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't mention the minimum required version enough 👁️ ?
You need Node.js 18.18.0 / 20.9.0 / 22.11.0 or higher for this guide (learn more about [system requirements](/orm/reference/system-requirements)). | |
You need Node.js 18.18.0 or higher for this guide (learn more about [system requirements](/orm/reference/system-requirements)). |
Same suggestion applies for the one above.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Afaiu the answer is actually no because e.g. a version like 19.0 or 20.1. wouldn't be supported, see here:
But I think you have a point that this may be confusing, I'll think about how to make this clearer 👍
- Node.js v16.13.0 or higher (learn more about [system requirements](/orm/reference/system-requirements)) | ||
|
||
> See [System requirements](/orm/reference/system-requirements) for exact version requirements. | ||
- [Node.js](https://nodejs.org/en/) installed on your machine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which version of node.js?
@@ -64,7 +64,7 @@ npm install prisma@latest --save-dev | |||
npm install @prisma/client@latest --save | |||
``` | |||
|
|||
### Step 2: Enable the feature flag in the Prisma schema file | |||
### 2. Enable the feature flag in the Prisma schema file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the numbering instead of the step 1
/step 2
-- it's more consistent with the rest of our docs.
|
||
</TabItem> | ||
|
||
<TabItem value="pnpm"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe also add bun @nikolasburk ?
...ent/200-orm/800-more/300-upgrade-guides/200-upgrading-versions/500-upgrading-to-prisma-6.mdx
Outdated
Show resolved
Hide resolved
### `tracing` | ||
|
||
If you use the [OpenTelemetry tracing](/orm/prisma-client/observability-and-logging/opentelemetry-tracing#about-tracing) in your app, you can now remove `tracing` from the `previewFeatures` in your Prisma schema: | ||
|
||
```prisma | ||
generator client { | ||
provider = "prisma-client-js" | ||
// delete-next-line | ||
previewFeatures = ["tracing"] | ||
} | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tentative, probably won't make it
…ions/500-upgrading-to-prisma-6.mdx Co-authored-by: Alexey Orlenko <[email protected]>
Resolves DA-1712