Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade docs to v6 #6445

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

upgrade docs to v6 #6445

wants to merge 9 commits into from

Conversation

nikolasburk
Copy link
Member

@nikolasburk nikolasburk commented Nov 20, 2024

Resolves DA-1712

Copy link
Contributor

Dangerous URL check

No absolute URLs to prisma.io/docs found.
No local URLs found.

Copy link
Contributor

github-actions bot commented Nov 20, 2024

original preview
content/200-orm/800-more/300-upgrade-guides/200-upgrading-versions/500-upgrading-to-prisma-6.mdx content/200-orm/800-more/300-upgrade-guides/200-upgrading-versions/500-upgrading-to-prisma-6.mdx
content/100-getting-started/01-quickstart-prismaPostgres.mdx content/100-getting-started/01-quickstart-prismaPostgres.mdx
content/100-getting-started/01-quickstart-sqlite.mdx content/100-getting-started/01-quickstart-sqlite.mdx
content/100-getting-started/02-setup-prisma/100-start-from-scratch/110-relational-databases-typescript-prismaPostgres.mdx content/100-getting-started/02-setup-prisma/100-start-from-scratch/110-relational-databases-typescript-prismaPostgres.mdx
content/200-orm/200-prisma-client/100-queries/050-filtering-and-sorting.mdx content/200-orm/200-prisma-client/100-queries/050-filtering-and-sorting.mdx
content/200-orm/200-prisma-client/100-queries/060-full-text-search.mdx content/200-orm/200-prisma-client/100-queries/060-full-text-search.mdx
content/200-orm/200-prisma-client/150-using-raw-sql/200-raw-queries.mdx content/200-orm/200-prisma-client/150-using-raw-sql/200-raw-queries.mdx
content/200-orm/200-prisma-client/200-special-fields-and-types/index.mdx content/200-orm/200-prisma-client/200-special-fields-and-types/index.mdx
content/200-orm/200-prisma-client/300-client-extensions/110-client.mdx content/200-orm/200-prisma-client/300-client-extensions/110-client.mdx
content/200-orm/200-prisma-client/600-observability-and-logging/240-metrics.mdx content/200-orm/200-prisma-client/600-observability-and-logging/240-metrics.mdx
content/200-orm/200-prisma-client/600-observability-and-logging/250-opentelemetry-tracing.mdx content/200-orm/200-prisma-client/600-observability-and-logging/250-opentelemetry-tracing.mdx
content/200-orm/500-reference/050-prisma-client-reference.mdx content/200-orm/500-reference/050-prisma-client-reference.mdx
content/200-orm/500-reference/100-prisma-schema-reference.mdx content/200-orm/500-reference/100-prisma-schema-reference.mdx
content/200-orm/500-reference/400-system-requirements.mdx content/200-orm/500-reference/400-system-requirements.mdx
content/200-orm/500-reference/500-preview-features/050-client-preview-features.mdx content/200-orm/500-reference/500-preview-features/050-client-preview-features.mdx
content/200-orm/800-more/300-upgrade-guides/200-upgrading-versions/600-upgrading-to-prisma-5/index.mdx content/200-orm/800-more/300-upgrade-guides/200-upgrading-versions/600-upgrading-to-prisma-5/index.mdx
content/200-orm/800-more/300-upgrade-guides/200-upgrading-versions/index.mdx content/200-orm/800-more/300-upgrade-guides/200-upgrading-versions/index.mdx

Copy link
Contributor

Redirect check

This PR probably requires the following redirects to be added to static/_redirects:

  • This PR does not change any pages in a way that would require a redirect.

Copy link

cloudflare-workers-and-pages bot commented Nov 20, 2024

Deploying docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: b825de5
Status:🚫  Build failed.

View logs

@@ -18,7 +18,7 @@ If you want to use Prisma ORM with your own PostgreSQL, MySQL, MongoDB or any ot

## Prerequisites

You need Node.js v16.13.0 or higher for this guide (learn more about [system requirements](/orm/reference/system-requirements)).
You need Node.js 18.18.0 / 20.9.0 / 22.11.0 or higher for this guide (learn more about [system requirements](/orm/reference/system-requirements)).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't mention the minimum required version enough 👁️ ?

Suggested change
You need Node.js 18.18.0 / 20.9.0 / 22.11.0 or higher for this guide (learn more about [system requirements](/orm/reference/system-requirements)).
You need Node.js 18.18.0 or higher for this guide (learn more about [system requirements](/orm/reference/system-requirements)).

Same suggestion applies for the one above.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Afaiu the answer is actually no because e.g. a version like 19.0 or 20.1. wouldn't be supported, see here:

image

But I think you have a point that this may be confusing, I'll think about how to make this clearer 👍

- Node.js v16.13.0 or higher (learn more about [system requirements](/orm/reference/system-requirements))

> See [System requirements](/orm/reference/system-requirements) for exact version requirements.
- [Node.js](https://nodejs.org/en/) installed on your machine
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which version of node.js?

@@ -64,7 +64,7 @@ npm install prisma@latest --save-dev
npm install @prisma/client@latest --save
```

### Step 2: Enable the feature flag in the Prisma schema file
### 2. Enable the feature flag in the Prisma schema file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the numbering instead of the step 1/step 2-- it's more consistent with the rest of our docs.


</TabItem>

<TabItem value="pnpm">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also add bun @nikolasburk ?

Comment on lines +244 to +254
### `tracing`

If you use the [OpenTelemetry tracing](/orm/prisma-client/observability-and-logging/opentelemetry-tracing#about-tracing) in your app, you can now remove `tracing` from the `previewFeatures` in your Prisma schema:

```prisma
generator client {
provider = "prisma-client-js"
// delete-next-line
previewFeatures = ["tracing"]
}
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tentative, probably won't make it

…ions/500-upgrading-to-prisma-6.mdx

Co-authored-by: Alexey Orlenko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants