Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace spawn with execa to fix Windows compatibility #37

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JohanManders
Copy link

Description

This PR replaces the usage of spawn with execa to resolve compatibility issues on Windows systems.

Changes Made

  • Replaced all occurrences of spawn with execa in the installStudio function.
  • Ensured that Prisma Studio runs asynchronously without blocking the execution of the rest of the code.

Issue

Should fix issues #35 and #13

Copy link

vercel bot commented Sep 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nuxt-prisma ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 9, 2024 11:44am

@BlueBazze
Copy link

It is technically possible that the user does not have npx installed.

Remember seeing this function, havent played with it.
https://devtools.nuxt.com/module/utils-kit#startsubprocess

@JohanManders
Copy link
Author

It is technically possible that the user does not have npx installed.

Remember seeing this function, havent played with it. https://devtools.nuxt.com/module/utils-kit#startsubprocess

The original implementation already relies on npx, as do several other functions within this file, so npx should be available in the environment where this code is running. Given that context, I believe the PR maintains consistency with the existing codebase without introducing additional dependencies.

@husayt
Copy link

husayt commented Nov 13, 2024

@ankur-arch this also looks like easy fix to another blocker. Will be great to adopt it

@ankur-arch
Copy link
Contributor

@husayt I'm currently cleaning up the repo and release process a bit. Will test and merge this soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants