Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retroactively add v0.11.7 & v0.11.8 #350

Merged
merged 1 commit into from
Jul 19, 2024

retroactively add v0.11.7 & v0.11.8

d8bc2ab
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

retroactively add v0.11.7 & v0.11.8 #350

retroactively add v0.11.7 & v0.11.8
d8bc2ab
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy succeeded Jul 19, 2024 in 1s

clippy

11 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 11
Note 0
Help 0

Versions

  • rustc 1.79.0 (129f3b996 2024-06-10)
  • cargo 1.79.0 (ffa9cf99a 2024-06-03)
  • clippy 0.1.79 (129f3b9 2024-06-10)

Annotations

Check warning on line 30 in src/tds/time.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

module has the same name as its containing module

warning: module has the same name as its containing module
  --> src/tds/time.rs:30:1
   |
30 | pub mod time;
   | ^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception
   = note: `#[warn(clippy::module_inception)]` on by default

Check warning on line 115 in src/tds/numeric.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

usage of a legacy numeric method

warning: usage of a legacy numeric method
   --> src/tds/numeric.rs:115:47
    |
115 |             let high_part = high_part * (u64::max_value() as u128 + 1);
    |                                               ^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
help: use the associated constant instead
    |
115 |             let high_part = high_part * (u64::MAX as u128 + 1);
    |                                               ~~~

Check warning on line 5 in src/tds/codec/type_info.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

importing legacy numeric constants

warning: importing legacy numeric constants
 --> src/tds/codec/type_info.rs:5:40
  |
5 | use std::{convert::TryFrom, sync::Arc, usize};
  |                                        ^^^^^
  |
  = help: remove this import
  = note: then `usize::<CONST>` will resolve to the respective associated constant
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants

Check warning on line 22 in src/macros.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

casting `tds::codec::login::FeatureLevel::SqlServerN` to `u8` will truncate the value

warning: casting `tds::codec::login::FeatureLevel::SqlServerN` to `u8` will truncate the value
  --> src/macros.rs:22:39
   |
22 |                       $( x if x == $ty::$variant as u8 => Ok($ty::$variant), )*
   |                                         ^^^^^^^^^^^^^^
   |
  ::: src/tds/codec/login.rs:9:1
   |
9  | / uint_enum! {
10 | |     #[repr(u32)]
11 | |     #[derive(PartialOrd)]
12 | |     pub enum FeatureLevel {
...  |
21 | |     }
22 | | }
   | |_- in this macro invocation
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_enum_truncation
   = note: this warning originates in the macro `uint_enum` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 22 in src/macros.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

casting `tds::codec::login::FeatureLevel::SqlServer2008R2` to `u8` will truncate the value

warning: casting `tds::codec::login::FeatureLevel::SqlServer2008R2` to `u8` will truncate the value
  --> src/macros.rs:22:39
   |
22 |                       $( x if x == $ty::$variant as u8 => Ok($ty::$variant), )*
   |                                         ^^^^^^^^^^^^^^
   |
  ::: src/tds/codec/login.rs:9:1
   |
9  | / uint_enum! {
10 | |     #[repr(u32)]
11 | |     #[derive(PartialOrd)]
12 | |     pub enum FeatureLevel {
...  |
21 | |     }
22 | | }
   | |_- in this macro invocation
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_enum_truncation
   = note: this warning originates in the macro `uint_enum` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 22 in src/macros.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

casting `tds::codec::login::FeatureLevel::SqlServer2008` to `u8` will truncate the value

warning: casting `tds::codec::login::FeatureLevel::SqlServer2008` to `u8` will truncate the value
  --> src/macros.rs:22:39
   |
22 |                       $( x if x == $ty::$variant as u8 => Ok($ty::$variant), )*
   |                                         ^^^^^^^^^^^^^^
   |
  ::: src/tds/codec/login.rs:9:1
   |
9  | / uint_enum! {
10 | |     #[repr(u32)]
11 | |     #[derive(PartialOrd)]
12 | |     pub enum FeatureLevel {
...  |
21 | |     }
22 | | }
   | |_- in this macro invocation
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_enum_truncation
   = note: this warning originates in the macro `uint_enum` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 22 in src/macros.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

casting `tds::codec::login::FeatureLevel::SqlServer2005` to `u8` will truncate the value

warning: casting `tds::codec::login::FeatureLevel::SqlServer2005` to `u8` will truncate the value
  --> src/macros.rs:22:39
   |
22 |                       $( x if x == $ty::$variant as u8 => Ok($ty::$variant), )*
   |                                         ^^^^^^^^^^^^^^
   |
  ::: src/tds/codec/login.rs:9:1
   |
9  | / uint_enum! {
10 | |     #[repr(u32)]
11 | |     #[derive(PartialOrd)]
12 | |     pub enum FeatureLevel {
...  |
21 | |     }
22 | | }
   | |_- in this macro invocation
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_enum_truncation
   = note: this warning originates in the macro `uint_enum` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 22 in src/macros.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

casting `tds::codec::login::FeatureLevel::SqlServer2000Sp1` to `u8` will truncate the value

warning: casting `tds::codec::login::FeatureLevel::SqlServer2000Sp1` to `u8` will truncate the value
  --> src/macros.rs:22:39
   |
22 |                       $( x if x == $ty::$variant as u8 => Ok($ty::$variant), )*
   |                                         ^^^^^^^^^^^^^^
   |
  ::: src/tds/codec/login.rs:9:1
   |
9  | / uint_enum! {
10 | |     #[repr(u32)]
11 | |     #[derive(PartialOrd)]
12 | |     pub enum FeatureLevel {
...  |
21 | |     }
22 | | }
   | |_- in this macro invocation
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_enum_truncation
   = note: this warning originates in the macro `uint_enum` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 22 in src/macros.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

casting `tds::codec::login::FeatureLevel::SqlServer2000` to `u8` will truncate the value

warning: casting `tds::codec::login::FeatureLevel::SqlServer2000` to `u8` will truncate the value
  --> src/macros.rs:22:39
   |
22 |                       $( x if x == $ty::$variant as u8 => Ok($ty::$variant), )*
   |                                         ^^^^^^^^^^^^^^
   |
  ::: src/tds/codec/login.rs:9:1
   |
9  | / uint_enum! {
10 | |     #[repr(u32)]
11 | |     #[derive(PartialOrd)]
12 | |     pub enum FeatureLevel {
...  |
21 | |     }
22 | | }
   | |_- in this macro invocation
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_enum_truncation
   = note: this warning originates in the macro `uint_enum` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 22 in src/macros.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

casting `tds::codec::login::FeatureLevel::SqlServerV7` to `u8` will truncate the value

warning: casting `tds::codec::login::FeatureLevel::SqlServerV7` to `u8` will truncate the value
  --> src/macros.rs:22:39
   |
22 |                       $( x if x == $ty::$variant as u8 => Ok($ty::$variant), )*
   |                                         ^^^^^^^^^^^^^^
   |
  ::: src/tds/codec/login.rs:9:1
   |
9  | / uint_enum! {
10 | |     #[repr(u32)]
11 | |     #[derive(PartialOrd)]
12 | |     pub enum FeatureLevel {
...  |
21 | |     }
22 | | }
   | |_- in this macro invocation
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_enum_truncation
   = note: `#[warn(clippy::cast_enum_truncation)]` on by default
   = note: this warning originates in the macro `uint_enum` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 60 in src/tds/codec/header.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

usage of a legacy numeric method

warning: usage of a legacy numeric method
  --> src/tds/codec/header.rs:60:32
   |
60 |         assert!(length <= u16::max_value() as usize);
   |                                ^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
   = note: `#[warn(clippy::legacy_numeric_constants)]` on by default
help: use the associated constant instead
   |
60 |         assert!(length <= u16::MAX as usize);
   |                                ~~~