Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added optional lang for retrieving docs & fixed unit test #40

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

plummoore
Copy link

No description provided.

@MarcMcIntosh
Copy link

MarcMcIntosh commented Oct 31, 2019

Test
test_doc.py -- tests.test_doc.DocTestCase
fails

Copy link

@MarcMcIntosh MarcMcIntosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests pass on tailsdotcom repository :)
Try and merge (locally) and re-test.

Copy link
Contributor

@srenault srenault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for you PR,
For get_by_uid, get_by_id, get_by_ids, the default language should be * (meaning we search over all languages). You can see how we did it for the javascript sdk here: https://github.com/prismicio/prismic-javascript/blob/master/src/ResolvedApi.ts#L182

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants