Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: key ID not being set correctly in keyshare JWTs #399

Merged
merged 3 commits into from
Feb 28, 2025

Conversation

ivard
Copy link
Member

@ivard ivard commented Feb 25, 2025

After some testing, I found that it was a server issue after all. This means that the irmaclient implementation is correct and that we can fix the issue by patching the server.

I updated the timestamp server in the testdata/irma_configuration to the new url and I used the testdata/makeschemes.sh script to update the testdata/irma_configuration_updated and the testdata/irma_configuration_invalid configurations.

@ivard ivard merged commit 5ab0cec into master Feb 28, 2025
17 checks passed
@ivard ivard deleted the fix-jwtkeys-kid-parsing branch February 28, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants