Merge im, teamchat and video-voice into real-time-communication #1136
Conversation
Mikaela
requested review from
nitrohorse,
jonaharagon,
blacklight447 and
a team
|
Deploy preview for privacytools-io ready! Built with commit 98bca69 |
_includes/nav.html
Outdated
| <a class="dropdown-item" href="/software/passwords/"><i class="fas fa-user-lock fa-fw"></i> Password Manager</a> | ||
| <a class="dropdown-item" href="/software/productivity/"><i class="fas fa-briefcase fa-fw"></i> Productivity Tools</a> | ||
| <a class="dropdown-item" href="/software/real-time-communication/"><i class="fab fa-telegram-plane fa-fw"></i> Real time communication</a> |
There was a problem hiding this comment.
Better icon suggestions?
There was a problem hiding this comment.
I forget which issue but I thought @jonaharagon had a recommendation for this...
| - /software/voip/ | ||
| - /software/teamchat/ | ||
| title: "Real time communication" | ||
| description: "Discover secure and private ways to communicate with others online without letting any third parties read your messages." |
There was a problem hiding this comment.
I thought that this was the best applying description to them all together.
There was a problem hiding this comment.
That sounds good to me.
|
|
||
| {% include sections/instant-messenger.html %} | ||
|
|
||
| <hr/> |
There was a problem hiding this comment.
I wish to have some separator between the different sections, even if they are on the same page.
There was a problem hiding this comment.
And I think this ordering makes the most sense as I think people are most often looking for instant messengers, then VoIP and team chat is a bit rarer scenario as I think that is mostly forced on people from whichever the team founder prefers.
There was a problem hiding this comment.
Yeah the breaks work well in my perspective.
|
Changed to Real-Time Communication as requested by @nitrohorse |
There was a problem hiding this comment.
I would rather do redirects with Nginx only I think, so as to not require too many Jekyll extensions on both the server and on local dev machines.
If we want, we could add an Nginx config file to this repo that would then be “include”d in the server config, so we can add redirects and other server-side configs here directly?
Oh nice, that sounds helpful 👍 |
Resolves: #1078
Closes: #746
Preview: https://deploy-preview-1136--privacytools-io.netlify.com/software/real-time-communication/