-
-
Notifications
You must be signed in to change notification settings - Fork 385
Redo of instant messenger section (centralized, federated, peer to peer) #1500
Redo of instant messenger section (centralized, federated, peer to peer) #1500
Conversation
Deploy preview for privacytools-io ready! Built with commit b0e178f |
https://github.com/dngray/ptio-edited-logos I put up the logos here, they got edited with a border. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have to pause reviewing to have a dinner, but I will continue from P2P as soon as I can.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nitpicks and general comments.
Another nit: There's also lot of text that says what E2EE stands for ("E2EE (end-to-end encryption)"), so it might feel better and less redundant if we just wrote out "end-to-end encryption". The Signal and Wire cards don't use "E2EE", for example
We explain what E2EE is so I've opted to use that throughout after explaining what the acronym means in the first paragraph privacytoolsIO/privacy-tools@4a368f9 I figured there's no point in having an acronym if we don't use it to make thing shorter. |
Also worth noting we'll need to create Discourse forum links for any new suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some suggestions, nice work so far!
I think this is a bit too big for me at the moment, but I will get back to this at a better time. I should be able to especially next week. |
Yes i had a note on my list to do this, i don't think i have permission to do that. |
This covers real-time communication. Aware of https://github.com/privacytoolsIO/privacytools.io/pull/1500, but that will be handled later.
This covers real-time communication. Aware of https://github.com/privacytoolsIO/privacytools.io/pull/1500, but that will be handled later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry @dngray, more things to address were given to me in private at Matrix
Assigning myself, so I maybe will remember to use the fine suggest changes button or may be sending PRs to your branch |
I added the netlify link to the original comment and I am not sure if the bridge/transport part was removed, but could it be noted that bridges/transports/relays turn federation/P2P into a single point of failure? And is the depedency on your server explained or do we consider that as too obvious? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Emergency approval before I leave from home as requested on the team chat, however I disagree with demoting XMPP.
(And my other change requests will probably need a new PR?)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
another emergency approval while I still disagree with the direction this PR took overnight.
Was this even something previously discussed? It was never full-recommended in the first place, this keeps it in the same position. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
duawdhuawhdawudh
Clarification on my previous comments: I woke up at 07.23 which is earlier than usually and left for psykofyysinen kuntoutus at 8.23 (where I arrived late). During this time I did my morning tasks and checked the PrivacyTools team chat where I learned that a blog post has been posted and this needs emergency merging immediately and that we have delisted XMPP. After I left from home, I was unable to reach other team members than @nitrohorse on XMPP and Wire (and we also established a Signal connection) who apologised for not understanding that I didn't have time for reviewing and clarified to me that we have not delisted XMPP and XMPP is still a worth mentioning app, which I can agree with). I also learned that as a backup to the teamchat on Matrix, we are having a backup chat on Keybase. However neither works on my main phone (and I was too di/stressed about everything to remember I have a powered off spare phone that Riot works on) as they are too heavy. I am not sure if RiotX has an issue about not performing well on Nokia 1, but at first it was showing me that everything is an encrypted message, then I maybe got two or three lines sent and read and as it then threw me to ancient history in the scrollback I attempted the clear cache and reload trick, which RiotX never continued further. I am aware that RiotX is an experimental app, but even with its malfunctioning, it works better and seems lighter than Riot. On Keybase, I have been complaining about it not working on my main phone for almost an year keybase/client#15115 and it's also one of the most heavy apps I run on my desktop (that has 8 GB RAM) alongside Riot, Signal and Wire. PS. I haven't still reviewed what has happened to this PR since my previous full review yesterday or earlier and I don't see much point doing that seeing that it has been merged already. PPS. I have no access to either team chat until around 14 UTC as the app is too heavy for my work try-out practice device with 4 GB of RAM that is efficiently eaten by Firefox, RocketChat, Riot and Telegram. |
I needed to add these icons because they did not exist.
The only one I needed to change was the XMPP logo, as it wasn't square, (only by a few pixels).
Matrix
I also edited the description for Matrix. Initially in https://github.com/privacytoolsIO/privacytools.io/issues/1377 I was going to mention about the privacy sprint. I think this might be a bit complex for new users and really unless they understand what those issues were about it serves little purpose in adding it.
Likewise the confusion between RiotX and regular Riot, I decided not to mention this as users should use what is generally available unless they know otherwise.
I also removed the Experimental E2EE badge as I do not believe that the previous description at all reflects the stability of E2EE in Riot currently which is pretty good, just need to remember to enable it.
XMPP
The original description is too complex so I decided to simplify that also. We won't talk about the bad XMPP clients just the ones we've handpicked.
Netlify preview: https://deploy-preview-1500--privacytools-io.netlify.com/software/real-time-communication/