fix caching of github api, only fetch 300 commits (#16)

* fix caching of github api, only fetch 300 commits * use string consistently for timestamps
private-attribution · Apr 25, 2024 · eb3db84 · eb3db84
1 parent 1c0c83d
commit eb3db84
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 6 deletions.
diff --git a/server/app/query/create/page.tsx b/server/app/query/create/page.tsx
@@ -182,7 +182,7 @@ function IPAForm({
       setBranches(_branches);
     };
     const fetchCommitHashes = async () => {
-      const _commitHashes = await Commits(owner, repo, false);
+      const _commitHashes = await Commits(owner, repo, false, 300);
       setCommitHashes(_commitHashes);
     };
     fetchBranches().catch(console.error);
@@ -192,7 +192,7 @@ function IPAForm({
   const refreshBranches = async (selectedCommitHash: string) => {
     const _branches = await Branches(owner, repo, true);
     setBranches(_branches);
-    const _commitHashes = await Commits(owner, repo, true);
+    const _commitHashes = await Commits(owner, repo, true, 300);
     setCommitHashes(_commitHashes);
   };
 

diff --git a/server/app/query/github.tsx b/server/app/query/github.tsx
@@ -31,7 +31,7 @@ export async function Branches(
     request: {
       cache: bypassCache ? "reload" : "default",
     },
-    timestamp: new Date().getTime(),
+    timestamp: bypassCache ? new Date().getTime().toString() : "",
   };
   const branchesIter = octokit.paginate.iterator(
     octokit.rest.repos.listBranches,
@@ -56,7 +56,7 @@ export async function Branches(
     request: {
       cache: bypassCache ? "reload" : "default",
     },
-    timestamp: new Date().getTime(),
+    timestamp: bypassCache ? new Date().getTime().toString() : "",
   };
 
   const pullRequestsIter = octokit.paginate.iterator(
@@ -86,6 +86,7 @@ export async function Commits(
   owner: string,
   repo: string,
   bypassCache: boolean,
+  maxCommits: number,
 ): Promise<string[]> {
   const requestParams: any = {
     owner: owner,
@@ -94,18 +95,23 @@ export async function Commits(
     request: {
       cache: bypassCache ? "reload" : "default",
     },
-    timestamp: new Date().getTime(),
+    timestamp: bypassCache ? new Date().getTime().toString() : "",
   };
   const commitsIter = octokit.paginate.iterator(
     octokit.rest.repos.listCommits,
     requestParams,
   );
 
   let commitsArray: string[] = [];
+  let pages: number = 0;
   for await (const { data: commits } of commitsIter) {
     for (const commit of commits) {
       commitsArray.push(commit.sha);
     }
+    pages++;
+    if (pages * 100 > maxCommits) {
+      break;
+    }
   }
   return commitsArray;
 }
diff --git a/server/next.config.js b/server/next.config.js
@@ -1,4 +1,10 @@
 /** @type {import('next').NextConfig} */
-const nextConfig = {}
+const nextConfig = {
+  logging: {
+    fetches: {
+      fullUrl: true,
+    },
+  },
+}
 
 module.exports = nextConfig