Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove multithreading and step generation #13

Merged
merged 1 commit into from
Apr 4, 2024
Merged

remove multithreading and step generation #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 2 additions & 26 deletions sidecar/app/query/ipa.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,36 +171,13 @@ def build_from_query(cls, query: IPAQuery):
def build_command(self) -> LoggerOutputCommand:
return LoggerOutputCommand(
cmd=f"cargo build --bin helper --manifest-path={self.manifest_path} "
f'--features="web-app real-world-infra compact-gate stall-detection '
f'multi-threading" --no-default-features --target-dir={self.target_path} '
f'--features="web-app real-world-infra compact-gate stall-detection" '
f"--no-default-features --target-dir={self.target_path} "
f"--release",
logger=self.logger,
)


@dataclass(kw_only=True)
class IPAHelperCollectStepsStep(CommandStep):
repo_path: Path
logger: loguru.Logger = field(repr=False)
status: ClassVar[Status] = Status.COMPILING

@classmethod
def build_from_query(cls, query: IPAQuery):
repo_path = query.paths.repo_path
return cls(
repo_path=repo_path,
logger=query.logger,
)

def build_command(self) -> FileOutputCommand:
output_file_path = self.repo_path / Path("ipa-core/src/protocol/step/steps.txt")
return FileOutputCommand(
cmd="python3 scripts/collect_steps.py -m",
cwd=self.repo_path,
output_file_path=output_file_path,
)


@dataclass(kw_only=True)
class IPACoordinatorGenerateTestDataStep(CommandStep):
output_file_path: Path
Expand Down Expand Up @@ -412,6 +389,5 @@ class IPAHelperQuery(IPAQuery):
IPAFetchUpstreamStep,
IPACheckoutCommitStep,
IPAHelperCompileStep,
IPAHelperCollectStepsStep,
IPAStartHelperStep,
]
Loading