-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prettier config #38
Prettier config #38
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Warning Rate limit exceeded@eriktaubeneck has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 38 minutes and 53 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. WalkthroughThis update introduces Prettier to the project's development workflow for consistent code formatting. It includes configuration files for Prettier and pre-commit hooks, updates to the README with setup instructions, and minor formatting changes in the codebase. Additionally, a new dependency on Prettier has been added to the server's Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
server/package-lock.json
is excluded by!**/package-lock.json
Files selected for processing (8)
- .git-blame-ignore-revs (1 hunks)
- .pre-commit-config.yaml (1 hunks)
- README.md (1 hunks)
- server/.prettierignore (1 hunks)
- server/.prettierrc (1 hunks)
- server/app/alert.tsx (1 hunks)
- server/app/query/haikunator.tsx (1 hunks)
- server/package.json (1 hunks)
Files skipped from review due to trivial changes (6)
- .git-blame-ignore-revs
- .pre-commit-config.yaml
- server/.prettierignore
- server/.prettierrc
- server/app/alert.tsx
- server/package.json
Additional context used
LanguageTool
README.md
[uncategorized] ~6-~6: “an” (indefinite article before a vowel sound) seems less likely than “and” (in addition to, following this). (AI_HYDRA_LEO_CP_AN_AND)
Context: ...ont end and service that starts queries an displays logs from the MPC helper serve...
[grammar] ~7-~7: “Sidecar” is a singular noun. It appears that the verb form is incorrect. (PCT_SINGULAR_NOUN_PLURAL_VERB_AGREEMENT)
Context: ...ervers 2. draft-sidecar: a sidecar back end API that runs next to the IPA binary on...
[uncategorized] ~16-~16: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short). (COMMA_COMPOUND_SENTENCE)
Context: ...ng Locally Make sure the repo is cloned and you're working in the root directory of...
[grammar] ~46-~46: Make sure that the noun ‘setup’ is correct. Did you mean the past participle “set up”? (BE_VB_OR_NN)
Context: ...ocker #### Pre-commit Hooks Github is setup to run pre-commit hooks specified in .p...
[uncategorized] ~170-~170: When ‘IPA-specific’ is used as a modifier, it is usually spelled with a hyphen. (SPECIFIC_HYPHEN)
Context: ...ivate pip install --editable . ``` ### IPA specific certs We check in self signed certs th...
[misspelling] ~172-~172: This word is normally spelled with a hyphen. (EN_COMPOUNDS_SELF_SIGNED)
Context: ...`` ### IPA specific certs We check in self signed certs that are only for local developme...
[misspelling] ~206-~206: This word is normally spelled as one. (EN_COMPOUNDS_SUB_DOMAINS)
Context: ...ike to use. You will need to create two sub-domains,sidecar.example.com
and `helper.exam...
[misspelling] ~206-~206: This word is normally spelled as one. (EN_COMPOUNDS_SUB_DOMAIN)
Context: ...ample.com. (Note, you could also use a sub-domain as your base domain, e.g.,
test.exampl...
[misspelling] ~206-~206: This word is normally spelled as one. (EN_COMPOUNDS_SUB_DOMAINS)
Context: ...main, e.g.,test.example.com
with two sub-domains of that:sidecar.test.example.com
and...
[misspelling] ~223-~223: Did you mean “once”? (ONE_ONCE)
Context: ...ryone's identity (e.g., 0, 1, 2, 3) One you know these: 1. Make a config direct...
[uncategorized] ~232-~232: When ‘IPA-specific’ is used as a modifier, it is usually spelled with a hyphen. (SPECIFIC_HYPHEN)
Context: ...le.com/privkey.pem key.pem5. Generate IPA specific keys: 1. Compile
ipawith
cargo ...
Markdownlint
README.md
13-13: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
23-23: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
50-50: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
64-64: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
83-83: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
215-215: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
223-223: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
239-239: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
248-248: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
249-249: Expected: 1; Actual: 3 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
1-1: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
250-250: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
9-9: null (MD025, single-title, single-h1)
Multiple top-level headings in the same document
250-250: null (MD025, single-title, single-h1)
Multiple top-level headings in the same document
32-32: null (MD031, blanks-around-fences)
Fenced code blocks should be surrounded by blank lines
139-139: null (MD031, blanks-around-fences)
Fenced code blocks should be surrounded by blank lines
158-158: null (MD031, blanks-around-fences)
Fenced code blocks should be surrounded by blank lines
164-164: null (MD031, blanks-around-fences)
Fenced code blocks should be surrounded by blank lines
193-193: null (MD031, blanks-around-fences)
Fenced code blocks should be surrounded by blank lines
198-198: null (MD031, blanks-around-fences)
Fenced code blocks should be surrounded by blank lines
39-39: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
68-68: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
192-192: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
199-199: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
219-219: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
225-225: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
69-69: null (MD034, no-bare-urls)
Bare URL used
70-70: null (MD034, no-bare-urls)
Bare URL used
51-51: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
65-65: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
84-84: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
106-106: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
143-143: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
188-188: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
18-18: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
26-26: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
32-32: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
55-55: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
78-78: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
86-86: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
92-92: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
98-98: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
110-110: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
116-116: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
128-128: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
134-134: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
139-139: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
149-149: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
158-158: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
164-164: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
176-176: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
193-193: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
242-242: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
Additional comments not posted (2)
server/app/query/haikunator.tsx (2)
9-16
: LGTM! The refactoring improves readability and consistency in date formatting.
20-22
: LGTM! UsingencodeURIComponent
enhances URL safety. Ensure all usages ofNewQueryId
are updated to handle the encoded format.
README.md
Outdated
@@ -41,6 +41,10 @@ Requirements: | |||
3. [Supabase CLI](https://supabase.com/docs/guides/cli/getting-started) | |||
4. Docker | |||
|
|||
#### Pre-commit Hooks | |||
|
|||
Github is setup to run pre-commit hooks specified in .pre-commit-config.yaml. If you want to use it locally, in the virtual environment, run `pre-commit install`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct the grammatical error for clarity.
- Github is setup to run pre-commit hooks specified in .pre-commit-config.yaml.
+ Github is set up to run pre-commit hooks specified in .pre-commit-config.yaml.
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Github is setup to run pre-commit hooks specified in .pre-commit-config.yaml. If you want to use it locally, in the virtual environment, run `pre-commit install`. | |
Github is set up to run pre-commit hooks specified in .pre-commit-config.yaml. If you want to use it locally, in the virtual environment, run `pre-commit install`. |
Tools
LanguageTool
[grammar] ~46-~46: Make sure that the noun ‘setup’ is correct. Did you mean the past participle “set up”? (BE_VB_OR_NN)
Context: ...ocker #### Pre-commit Hooks Github is setup to run pre-commit hooks specified in .p...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 on adding a formatter. One enforceable way to write code makes collaboration easier
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- server/.prettierignore (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- server/.prettierignore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- README.md (1 hunks)
Additional context used
LanguageTool
README.md
[grammar] ~6-~6: The plural noun “displays” cannot be used with the article “an”. Did you mean “an display” or “displays”? (A_NNS)
Context: ...ont end and service that starts queries an displays logs from the MPC helper servers 2. dra...
[grammar] ~7-~7: “Sidecar” is a singular noun. It appears that the verb form is incorrect. (PCT_SINGULAR_NOUN_PLURAL_VERB_AGREEMENT)
Context: ...ervers 2. draft-sidecar: a sidecar back end API that runs next to the IPA binary on...
[uncategorized] ~16-~16: Use a comma before ‘and’ if it connects two independent clauses (unless they are closely connected and short). (COMMA_COMPOUND_SENTENCE)
Context: ...ng Locally Make sure the repo is cloned and you're working in the root directory of...
[uncategorized] ~170-~170: When ‘IPA-specific’ is used as a modifier, it is usually spelled with a hyphen. (SPECIFIC_HYPHEN)
Context: ...ivate pip install --editable . ``` ### IPA specific certs We check in self signed certs th...
[misspelling] ~172-~172: This word is normally spelled with a hyphen. (EN_COMPOUNDS_SELF_SIGNED)
Context: ...`` ### IPA specific certs We check in self signed certs that are only for local developme...
[misspelling] ~206-~206: This word is normally spelled as one. (EN_COMPOUNDS_SUB_DOMAINS)
Context: ...ike to use. You will need to create two sub-domains,sidecar.example.com
and `helper.exam...
[misspelling] ~206-~206: This word is normally spelled as one. (EN_COMPOUNDS_SUB_DOMAIN)
Context: ...ample.com. (Note, you could also use a sub-domain as your base domain, e.g.,
test.exampl...
[misspelling] ~206-~206: This word is normally spelled as one. (EN_COMPOUNDS_SUB_DOMAINS)
Context: ...main, e.g.,test.example.com
with two sub-domains of that:sidecar.test.example.com
and...
[misspelling] ~223-~223: Did you mean “once”? (ONE_ONCE)
Context: ...ryone's identity (e.g., 0, 1, 2, 3) One you know these: 1. Make a config direct...
[uncategorized] ~232-~232: When ‘IPA-specific’ is used as a modifier, it is usually spelled with a hyphen. (SPECIFIC_HYPHEN)
Context: ...le.com/privkey.pem key.pem5. Generate IPA specific keys: 1. Compile
ipawith
cargo ...
Markdownlint
README.md
13-13: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
23-23: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
50-50: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
64-64: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
83-83: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
215-215: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
223-223: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
239-239: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
248-248: Expected: 1; Actual: 2 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
249-249: Expected: 1; Actual: 3 (MD012, no-multiple-blanks)
Multiple consecutive blank lines
1-1: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
250-250: Expected: 1; Actual: 0; Below (MD022, blanks-around-headings)
Headings should be surrounded by blank lines
9-9: null (MD025, single-title, single-h1)
Multiple top-level headings in the same document
250-250: null (MD025, single-title, single-h1)
Multiple top-level headings in the same document
32-32: null (MD031, blanks-around-fences)
Fenced code blocks should be surrounded by blank lines
139-139: null (MD031, blanks-around-fences)
Fenced code blocks should be surrounded by blank lines
158-158: null (MD031, blanks-around-fences)
Fenced code blocks should be surrounded by blank lines
164-164: null (MD031, blanks-around-fences)
Fenced code blocks should be surrounded by blank lines
193-193: null (MD031, blanks-around-fences)
Fenced code blocks should be surrounded by blank lines
198-198: null (MD031, blanks-around-fences)
Fenced code blocks should be surrounded by blank lines
39-39: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
68-68: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
192-192: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
199-199: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
219-219: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
225-225: null (MD032, blanks-around-lists)
Lists should be surrounded by blank lines
69-69: null (MD034, no-bare-urls)
Bare URL used
70-70: null (MD034, no-bare-urls)
Bare URL used
51-51: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
65-65: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
84-84: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
106-106: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
143-143: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
188-188: null (MD036, no-emphasis-as-heading)
Emphasis used instead of a heading
18-18: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
26-26: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
32-32: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
55-55: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
78-78: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
86-86: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
92-92: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
98-98: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
110-110: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
116-116: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
128-128: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
134-134: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
139-139: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
149-149: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
158-158: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
164-164: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
176-176: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
193-193: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
242-242: null (MD040, fenced-code-language)
Fenced code blocks should have a language specified
Additional comments not posted (1)
README.md (1)
46-46
: Corrected grammatical error in the setup description.This change improves the clarity of the documentation by using the correct form "set up" instead of "setup".
I had been using this locally, but now it's part of the pre-commit hooks and CI.
Summary by CodeRabbit
New Features
.prettierignore
file to exclude specific files and directories from Prettier formatting in theserver
directory.Chores
.pre-commit-config.yaml
for theserver
directory.prettier
dependency version3.3.1
inserver/package.json
.Style
server/app/alert.tsx
andserver/app/query/haikunator.tsx
for better readability.