Merge pull request #860 from martinthomson/ba-from

Lints generally exist for a good reason
private-attribution · Nov 24, 2023 · 9d81922 · 9d81922
2 parents 7240cac + 17e0880
commit 9d81922
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/src/ff/boolean_array.rs b/src/ff/boolean_array.rs
@@ -191,16 +191,14 @@ macro_rules! boolean_array_impl {
                 }
             }
 
-            #[allow(clippy::from_over_into)]
-            impl Into<u128> for $name {
+            impl From<$name> for u128 {
                 /// Infallible conversion from this data type to `u128`. We assume that the
                 /// inner value is at most 128-bit long. That is, the integer value must be
                 /// less than or equal to `2^Self::BITS`. Should be long enough for our use
                 /// case.
-                fn into(self) -> u128 {
+                fn from(v: $name) -> u128 {
                     debug_assert!(<$name>::BITS <= 128);
-                    self.0
-                        .iter()
+                    v.0.iter()
                         .by_refs()
                         .enumerate()
                         .fold(0_u128, |acc, (i, b)| acc + ((*b as u128) << i))