-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breakdown reveal aggregation test hangs sometimes #1312
Comments
it is still happening: https://github.com/private-attribution/ipa/actions/runs/11136370331/job/30948030558?pr=1327 even after #1325 |
The current failure symptom is slightly different than the original. I'm also not clear on the relation between this issue and the stack overflow issue. Is it possible that the iteration reduction in #1314 was not necessary, and if that's the case, do we want to revert it? If some of the stack overflows are manifesting as hangs, should that be tracked as a separate issue from the overflows themselves? |
Yea we probably want @cberkhoff here as he was investigating that issue. I don't think I have good understanding whether these hangs were caused by stack overflows or not. |
Potentially, I am still suspicious about the time it takes to finish this test
these are very long waits, so it could be Shuttle running in circles somewhere |
The stack overflows were causing the test to fail, not hang. |
hmm, that's weird. Do you have an example of such failure on the CI? |
Some further observations about
I am still not sure which of the following is/are true of the failures in CI:
|
One thing I noticed when working with Shuttle is that it does not like standard rng. It vends its own random generator which should be used instead: https://docs.rs/shuttle/latest/shuttle/rand/index.html. I think we export that as rng. If DP padding uses RNG to generate dummies (which I believe it does), it could be worth replacing it with |
new hang - now w/o shuttle: https://github.com/private-attribution/ipa/actions/runs/11812643390/job/32908176314 |
we can try to reproduce it with this seed: 4039690703696284216
https://github.com/private-attribution/ipa/actions/runs/11018449181/job/30598750956?pr=1307
The text was updated successfully, but these errors were encountered: