Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plumb padding parameters to breakdown_reveal_aggregation #1331

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

andyleiserson
Copy link
Collaborator

Use the relaxed parameters for most tests, and disable padding for the end-to-end malicious test when running under shuttle.

I believe this will resolve the newer failure symptom in #1312.

Use the relaxed parameters for most tests, and disable padding for the
end-to-end malicious test when running under shuttle.
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

Attention: Patch coverage is 96.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.52%. Comparing base (a55a3b4) to head (c8a0281).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
ipa-core/src/protocol/ipa_prf/mod.rs 83.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1331   +/-   ##
=======================================
  Coverage   93.52%   93.52%           
=======================================
  Files         208      208           
  Lines       33872    33891   +19     
=======================================
+ Hits        31679    31697   +18     
- Misses       2193     2194    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andyleiserson andyleiserson merged commit 9c834cc into private-attribution:main Oct 3, 2024
12 checks passed
@andyleiserson andyleiserson deleted the padding branch October 3, 2024 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants