Compact gate follow up #1078
Merged
Compact gate follow up #1078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
make an associated generic type, rather than method
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1078 +/- ##
==========================================
+ Coverage 90.82% 90.85% +0.02%
==========================================
Files 184 183 -1
Lines 25713 25695 -18
==========================================
- Hits 23355 23344 -11
+ Misses 2358 2351 -7 ☔ View full report in Codecov by Sentry. |
benjaminsavage
approved these changes
May 20, 2024
| Self::Bit(usize::try_from(v).unwrap()) | ||
| } | ||
| } | ||
| #[step(count = 512, child = crate::protocol::boolean::step::EightBitStep, name = "b")] |
There was a problem hiding this comment.
I think we should keep the comment about keeping this in sync with MAX_BREAKDOWNS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses most of the comments from #961 PR.