Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise comment about chunk override for attribution #1376

Merged
merged 2 commits into from
Oct 28, 2024
Merged

Revise comment about chunk override for attribution #1376

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70cd2ef
Remove chunk override for attribution
andyleiserson Oct 25, 2024
554c891
Restore chunk override; revise comment
andyleiserson Oct 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ipa-core/src/protocol/ipa_prf/prf_sharding/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -511,8 +511,9 @@ where
protocol: &Step::Attribute,
validate: &Step::AttributeValidate,
},
// TODO: this should not be necessary, but probably can't be removed
// until we align read_size with the batch size.
// TODO: this override was originally added to work around problems with
// read_size vs. batch size alignment. Those are now fixed (in #1332), but this
// is still observed to help performance (see #1376), so has been retained.
std::cmp::min(sh_ctx.active_work().get(), chunk_size.next_power_of_two()),
);
dzkp_validator.set_total_records(TotalRecords::specified(histogram[1]).unwrap());
Expand Down