Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate IPA code to new metrics engine #1379

Merged
merged 3 commits into from
Oct 29, 2024

Feedback

69a9442
Select commit
Loading
Failed to load commit list.
Merged

Migrate IPA code to new metrics engine #1379

Feedback
69a9442
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 28, 2024 in 0s

93.63% (target 85.00%)

View this Pull Request on Codecov

93.63% (target 85.00%)

Details

Codecov Report

Attention: Patch coverage is 71.97802% with 51 lines in your changes missing coverage. Please review.

Project coverage is 93.63%. Comparing base (57e2c63) to head (69a9442).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
ipa-core/src/bin/helper.rs 5.40% 35 Missing ⚠️
ipa-core/src/cli/metric_collector.rs 50.00% 12 Missing ⚠️
ipa-core/src/helpers/mod.rs 88.00% 3 Missing ⚠️
ipa-core/src/telemetry/step_stats.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1379      +/-   ##
==========================================
+ Coverage   93.54%   93.63%   +0.08%     
==========================================
  Files         222      223       +1     
  Lines       36986    36998      +12     
==========================================
+ Hits        34600    34644      +44     
+ Misses       2386     2354      -32

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov