Hybrid query #1468
Closed
Hybrid query #1468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eriktaubeneck
force-pushed
the
hybrid-query
branch
2 times, most recently
from
9c35083 to
5a31178
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1468 +/- ##
==========================================
- Coverage 93.11% 93.03% -0.09%
==========================================
Files 236 236
Lines 42853 42892 +39
==========================================
Hits 39903 39903
- Misses 2950 2989 +39 ☔ View full report in Codecov by Sentry. |
akoshelev
reviewed
Dec 3, 2024
|
@akoshelev agreed. this will require an integration test, yea? @tyurek is making progress on #1469, which should then allow us to write an integration test for this. |
akoshelev
reviewed
Dec 5, 2024
ipa-core/src/query/runner/hybrid.rs
Outdated
| let ctx = ShardedMaliciousContext::new_with_gate(prss, gateway, gate, sharded); | ||
|
|
||
| // TODO: load this from individual reports | ||
| let hybrid_info = |
There was a problem hiding this comment.
@tyurek is it something you would need to fix along with the AAD change?
There was a problem hiding this comment.
actually this should be fixed. I'll find time to rebase this evening
akoshelev
approved these changes
Dec 5, 2024
eriktaubeneck
force-pushed
the
hybrid-query
branch
from
5a31178 to
4bff1d6
Compare
|
this is included in #1479, so closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding one more layer of plumbing to actually running a hybrid query.
This is an early draft to get some input on the direction. We likely won't want to merge this until @tyurek's work to load the
HybridInfofrom the reports directly is complete.