Add Hybrid Encryption/Decryption to CLI #1478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1478 +/- ##
==========================================
- Coverage 93.74% 93.34% -0.40%
==========================================
Files 235 238 +3
Lines 42679 43318 +639
==========================================
+ Hits 40011 40437 +426
- Misses 2668 2881 +213 ☔ View full report in Codecov by Sentry. |
akoshelev
approved these changes
Dec 5, 2024
Comment on lines
159
to
171
| /*let files = [ | ||
| &output_dir.path().join("helper1.enc"), | ||
| &output_dir.path().join("helper2.enc"), | ||
| &output_dir.path().join("helper3.enc"), | ||
| ]; | ||
|
|
||
| let world = TestWorld::default(); | ||
|
|
||
| let mk_private_keys = [ | ||
| "53d58e022981f2edbf55fec1b45dbabd08a3442cb7b7c598839de5d7a5888bff", | ||
| "3a0a993a3cfc7e8d381addac586f37de50c2a14b1a6356d71e94ca2afaeb2569", | ||
| "1fb5c5274bf85fbe6c7935684ef05499f6cfb89ac21640c28330135cc0e8a0f7", | ||
| ];*/ |
There was a problem hiding this comment.
Suggested change
| /*let files = [ | |
| &output_dir.path().join("helper1.enc"), | |
| &output_dir.path().join("helper2.enc"), | |
| &output_dir.path().join("helper3.enc"), | |
| ]; | |
| let world = TestWorld::default(); | |
| let mk_private_keys = [ | |
| "53d58e022981f2edbf55fec1b45dbabd08a3442cb7b7c598839de5d7a5888bff", | |
| "3a0a993a3cfc7e8d381addac586f37de50c2a14b1a6356d71e94ca2afaeb2569", | |
| "1fb5c5274bf85fbe6c7935684ef05499f6cfb89ac21640c28330135cc0e8a0f7", | |
| ];*/ |
There was a problem hiding this comment.
yeah, I'm basically trying to avoid relying on the other code at all, so lots of duplication
tyurek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm going to tidy this up in a bit, but the functionality is there I believe. Let me know if I missed something important