-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Fixed-Rate Polling Specifier To ReportCollector #1492
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1492 +/- ##
==========================================
- Coverage 93.29% 93.27% -0.03%
==========================================
Files 237 237
Lines 43510 43518 +8
==========================================
- Hits 40592 40590 -2
- Misses 2918 2928 +10 ☔ View full report in Codecov by Sentry. |
ipa-core/src/bin/report_collector.rs
Outdated
// If set, use the specified fixed polling interval when running a query. | ||
// Otherwise, use exponential backoff. | ||
#[arg(long, default_value_t = 0)] | ||
set_fixed_polling_ms: u64, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is Option<u64>
better to represent this value being not set?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, yeah, probably
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting interval in millis is not great but probably the best we can do without polling extra crates. Humans tend to make typo errors when entering large numbers and if we want to poll every 5 mins, 300000 vs 30000 makes a big difference
Are we expecting to have large polling intervals like that? |
To test this, I added
.args(["--set-fixed-polling-ms", "100"])
before line 93 in the file containingtest_hybrid()
. I also verified that it fails with bad argumentsTest ran with
cargo test --package ipa-core --test hybrid --no-default-features --features "cli compact-gate web-app real-world-infra test-fixture relaxed-dp multi-threading" -- test_hybrid --exact
I should say this usually passes... I ran it once (with the argument specified) and got
But I don't think that's due to any incorrect logic in this PR