Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swap unwrap with ? #1495

Merged

Conversation

eriktaubeneck
Copy link
Member

We previously used unwrap before the protocol was complete (and caught the panic in the test). Now that we don't expect this to panic, we should use ?.

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.29%. Comparing base (4f112ad) to head (df57252).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1495   +/-   ##
=======================================
  Coverage   93.29%   93.29%           
=======================================
  Files         237      237           
  Lines       43510    43510           
=======================================
  Hits        40592    40592           
  Misses       2918     2918           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eriktaubeneck eriktaubeneck merged commit fa74e23 into private-attribution:main Dec 12, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants