Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache DNS responses for IpaClients #1496

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

akoshelev
Copy link
Collaborator

Our client is not a general-purpose HTTP client and talks to only limited subset of services, so caching will be effective here to prevent overloading DNS

Our client is not a general-purpose HTTP client and talks to only limited subset of services, so caching will be effective here to prevent overloading DNS
@akoshelev akoshelev marked this pull request as draft December 13, 2024 08:39
@akoshelev
Copy link
Collaborator Author

I am seeing test hangs when running them locally, so I don't think this is ready to be merged. I can't figure out why it may be caused by the cache (we only resolve localhost and I confirmed that it does not block on Dashmap) but it is always DNS...

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 95.34884% with 4 lines in your changes missing coverage. Please review.

Project coverage is 93.24%. Comparing base (fa74e23) to head (fd6f313).

Files with missing lines Patch % Lines
ipa-core/src/net/client/dns.rs 95.18% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1496      +/-   ##
==========================================
+ Coverage   93.23%   93.24%   +0.01%     
==========================================
  Files         237      238       +1     
  Lines       43534    43617      +83     
==========================================
+ Hits        40587    40672      +85     
+ Misses       2947     2945       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant