Upgrade jemalloc to 0.6; add jemalloc feature #1502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jemalloc is used by default on linux. The feature enables it on non-linux platforms.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1502 +/- ##
==========================================
+ Coverage 93.02% 93.24% +0.21%
==========================================
Files 237 237
Lines 43535 43535
==========================================
+ Hits 40498 40593 +95
+ Misses 3037 2942 -95 ☔ View full report in Codecov by Sentry. |
|
+1 on doing a draft run before merging this |
akoshelev
approved these changes
Dec 17, 2024
|
Draft run is at https://draft-mpc.vercel.app/query/view/briny-hand2024-12-17T0158. |
|
Draft run took 1:51, no change from previous. I also did some further investigation to convince myself that this PR really does have profiling disabled. Since I'm curious, I opened a new one (#1505) to see if there is a performance impact of turning it on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jemalloc is used by default on linux. The feature enables it on non-linux platforms.
The
statsfeature is enabled by default on version 0.5 of thetikv-jemalloc-ctlcrate. It needs to be specified on version 0.6 of the crate. I figured might as well upgrade the jemalloc bits now, when I'm aware of the breaking change, than have to remember (or somebody else rediscover) it later.The jemalloc profiling enables are a bit confusing. This PR does not have all of the config that I set to do memory profiling. My intent was to have it compiled-in-but disabled, but I'm not sure that's actually what this PR does. I will do a draft run to check whether there is a performance impact.