-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Query input from URL #1508
Query input from URL #1508
Conversation
This should result in it running on the HTTP runtime. Doing it in the query processor would have it on the query runtime (absent other changes to runtime plumbing).
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1508 +/- ##
==========================================
- Coverage 93.24% 93.19% -0.06%
==========================================
Files 238 241 +3
Lines 43688 43966 +278
==========================================
+ Hits 40739 40975 +236
- Misses 2949 2991 +42 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets ship it - tests for test_mpc will be added in #1510
Support for helper to pull query input from a URL, rather than receiving it directly from the client in an HTTP request body.
Also adds a simple HTTP server in test_mpc to serve local files, for testing purposes.