Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query input from URL #1508

Merged

Conversation

andyleiserson
Copy link
Collaborator

Support for helper to pull query input from a URL, rather than receiving it directly from the client in an HTTP request body.

Also adds a simple HTTP server in test_mpc to serve local files, for testing purposes.

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 80.29557% with 40 lines in your changes missing coverage. Please review.

Project coverage is 93.19%. Comparing base (6531c97) to head (7d91b4f).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
ipa-core/src/helpers/transport/query/mod.rs 55.55% 12 Missing ⚠️
ipa-core/src/net/query_input.rs 68.42% 12 Missing ⚠️
ipa-core/src/bin/test_mpc.rs 9.09% 10 Missing ⚠️
ipa-core/src/net/server/handlers/query/input.rs 96.92% 2 Missing ⚠️
ipa-core/src/query/processor.rs 81.81% 2 Missing ⚠️
ipa-core/src/app.rs 90.90% 1 Missing ⚠️
ipa-core/src/cli/playbook/hybrid.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1508      +/-   ##
==========================================
- Coverage   93.24%   93.19%   -0.06%     
==========================================
  Files         238      241       +3     
  Lines       43688    43966     +278     
==========================================
+ Hits        40739    40975     +236     
- Misses       2949     2991      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@akoshelev akoshelev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets ship it - tests for test_mpc will be added in #1510

@andyleiserson andyleiserson merged commit fc61e53 into private-attribution:main Dec 20, 2024
13 checks passed
@andyleiserson andyleiserson deleted the query-input-from-url branch December 20, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants