Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Idle tracking in gate way #765

Closed
wants to merge 38 commits into from
Closed

Idle tracking in gate way #765

wants to merge 38 commits into from

Conversation

RuiyuZhu
Copy link

No description provided.

Ruiyu Zhu added 30 commits July 13, 2023 10:48
Add an idle tracker for ordering_sender and corresponding State
30cf975 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
add idle tracking in GateWaySenders
37b2349 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
add periodical idle checking in gateway for the sender side
a9f5837 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
add idle tracker for unorder_receiver
f07859f 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
add idle track for gateway receiver
30b377b 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Use receiver idle tracker in the periodical task as well
c8f7fcb 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Add printing info about messages waiting to be sent
ed22220 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Merge is_idle() and reset_idle() to check_and_reset_idle()
4c9ebbc 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Skip mutex for gateway sender and receiver
1a2671e 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
use tokio spawn instead of thread
8822342 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Put the tracker in debug only mode
e6bd0a0 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Add logging for receiver's record
3e4cfc7 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Track missing messages on senders
13387b2 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Use #[cfg(debug_assertions)] to replace "if cfg!(debug_assertions)"
6f94045 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Use a type to represent Sender's status
eb77400 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Skip empty recording when printing gateway info
cfcc370 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
extract waiting messages from wakers
4b20df8 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Clamp the list of pending messages
046c81d 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Use tracing::warn! instead of println, skip threadId
bf318e9 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
tracking waiting message in ordering_senders
23b782a 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Skip Arc if it is not debug mod
acec76c 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Convert missing message index to string in gateway
27d399d 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Use group_by to fold indexes
226727d 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Correct the type for non-debug version
27a1b8e 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
delete commented code
4f0c3a3 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
move idle set from take to write for send
0f1aecb 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
move idle tracking to a wrap class
fc887e0 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
move idle tracker to a debug-only wrap as well
111c740 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Add LoggingRanges type to abstract away the details
de2801d 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Remove unnecessary clone
b16041a 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Ruiyu Zhu added 8 commits July 21, 2023 10:29
Fix format issues
b9ee7a2 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Remove pub notation for inner
30a574a 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Address pre-commit issues
f674450 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Wrap class for ordering_sender
7b050ea 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
Add a wrap class for unorder_receiver
ea81aed 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
.
33db1bc
.
976f88e
fix debug/release warnings
3ab7610 
Summary:

Test Plan:

Reviewers:

Subscribers:

Tasks:

Tags:
@benjaminsavage
Copy link
Collaborator

Can we close this PR?

@akoshelev
Copy link
Collaborator

Can we close this PR?

this requires a bit more work as I recently discovered we have an issue with closed receive channels. I am planning to work on it once the first version of multi-threading seq_try_join_all is out

@akoshelev akoshelev mentioned this pull request Nov 3, 2023
Merged
@akoshelev
Copy link
Collaborator

Updated to match current infra in #832

@akoshelev akoshelev closed this Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@RuiyuZhu @benjaminsavage @akoshelev