Prf eval #795
Closed
Prf eval #795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/ff/curve_points.rs
Outdated
| type Output = Self; | ||
|
|
||
| fn add(self, rhs: Self) -> Self::Output { | ||
| Self((self.0.decompress().unwrap()+rhs.0.decompress().unwrap()).compress()) |
There was a problem hiding this comment.
This is potentially problematic. Do we really want to do compression and decompression for every local operation? Could we instead store this object uncompressed and only compress when we sent it out?
There was a problem hiding this comment.
Probably need to look more detailed into the tradeoff between memory cost vs cpu. I think decompressed points take 3 times more memory (I haven't checked how costly the compression is). Currently we do not do much arithmetics on curve points, just one scalar multiplication and one reveal which reconstructs the shares using two additions per party.
added 3 commits
October 9, 2023 15:03
akoshelev
reviewed
Oct 11, 2023
Co-authored-by: Alex Koshelev <[email protected]>
Co-authored-by: Alex Koshelev <[email protected]>
Co-authored-by: Alex Koshelev <[email protected]>
Co-authored-by: Alex Koshelev <[email protected]>
…F-Eval # Conflicts: # src/protocol/ipa_prf/prf_sharding/bucket.rs
|
closed, see #833 (same functionality, cleaned up commit history) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implementation of DY evaluation protocol based on replicated secret sharing