Real world test #822
Merged
Real world test #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminsavage
approved these changes
Oct 30, 2023
src/query/runner/oprf_ipa.rs
Outdated
| let sz = usize::from(query_size); | ||
|
|
||
| let input = if config.plaintext_match_keys { | ||
| let mut v = assert_stream_send(RecordsStream::< |
There was a problem hiding this comment.
Do we absolutely need this "assert_stream_send" call? Can you try to remove that and see if it compiles?
akoshelev
requested changes
Oct 30, 2023
| @@ -24,6 +24,11 @@ pub enum IpaSecurityModel { | |||
| Malicious, | |||
| } | |||
|
|
|||
| pub enum IpaQueryStyle { | |||
There was a problem hiding this comment.
so many types of ipa queries...
richajaindce
force-pushed
the
real_world
branch
from
4a65f64 to
0e9f41b
Compare
src/cli/playbook/ipa.rs
Outdated
| do_processing::<F>(inputs, query_size, clients, query_id, query_config).await | ||
| } | ||
|
|
||
| pub async fn do_processing<F>( |
There was a problem hiding this comment.
Let's select a better name =)
benjaminsavage
merged commit b4760d9
into
private-attribution:main
4 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.