Move u128 conversions out of Field trait #954
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a lot of changed files, but most of them are only changed to update references to
Field
orU128Conversions
traits. The core change here is that thetruncate_from
andas_u128
methods are removed from theField
trait and put in the newU128Conversions
trait, because the u128 conversions do not make sense onFp25519
.There are some more substantial upcoming changes that will resolve the remaining issues with the
Field
trait and clean up the TODOs in this PR.