Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move u128 conversions out of Field trait #954

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

andyleiserson
Copy link
Collaborator

There are a lot of changed files, but most of them are only changed to update references to Field or U128Conversions traits. The core change here is that the truncate_from and as_u128 methods are removed from the Field trait and put in the new U128Conversions trait, because the u128 conversions do not make sense on Fp25519.

There are some more substantial upcoming changes that will resolve the remaining issues with the Field trait and clean up the TODOs in this PR.

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (860e046) 88.44% compared to head (8433d08) 88.43%.

Files Patch % Lines
ipa-core/src/test_fixture/mod.rs 20.00% 4 Missing ⚠️
ipa-core/src/test_fixture/circuit.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #954      +/-   ##
==========================================
- Coverage   88.44%   88.43%   -0.01%     
==========================================
  Files         158      158              
  Lines       21472    21472              
==========================================
- Hits        18991    18989       -2     
- Misses       2481     2483       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akoshelev
Copy link
Collaborator

oof merging it with ipa v2 removal change will be fun

@andyleiserson andyleiserson merged commit 9e5a4d4 into private-attribution:main Feb 21, 2024
11 checks passed
@andyleiserson andyleiserson deleted the u128 branch February 21, 2024 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants