add command line flag to collect_steps.py for multi-threading #966
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scripts/collect_steps.py
Outdated
Comment on lines
173
to
175
| features = "enable-benches debug-trace step-trace" | ||
| if args.multi_threading: | ||
| features = f"{features} multi-threading" |
There was a problem hiding this comment.
Shouldn't this use a list and " ".join()?
There was a problem hiding this comment.
if we wanted to make this more flexible (e.g., add other flags too), that's how I'd do it. @akoshelev suggested the steps concept was going away soon, so I just did this quick an dirty.
There was a problem hiding this comment.
we are probably still going to use steps, but this script should go away after #961
akoshelev
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding a small update to the
collect_steps.pyscript to have the option for multithreading.