removing one more iter_mut in the denominators #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akoshelev
approved these changes
Mar 16, 2024
| } | ||
| *d = d.invert(); | ||
| Self { | ||
| denominator: (0..u128::from(N::U64)) |
There was a problem hiding this comment.
shouldn't N::U128 work out of the box w/o extra casts here? https://docs.rs/typenum/latest/typenum/marker_traits/trait.Unsigned.html#associatedconstant.U128
There was a problem hiding this comment.
You are right. @martinthomson helped me figure out we could get this by bumping the version of typenum
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #977 +/- ##
==========================================
- Coverage 89.34% 89.27% -0.07%
==========================================
Files 161 161
Lines 21887 21900 +13
==========================================
- Hits 19555 19552 -3
- Misses 2332 2348 +16 ☔ View full report in Codecov by Sentry. |
benjaminsavage
commented
Mar 16, 2024
| @@ -149,7 +149,7 @@ tower = { version = "0.4.13", optional = true } | |||
| tower-http = { version = "0.4.0", optional = true, features = ["trace"] } | |||
| tracing = "0.1" | |||
| tracing-subscriber = { version = "0.3", features = ["env-filter"] } | |||
| typenum = "1.16" | |||
| typenum = { version = "1.17", features = ["i128"] } | |||
There was a problem hiding this comment.
Required to unlock the N::U128 constants
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Really minor change to remove one more iter_mut