Pinned pylint to 2.6 and updated the configs accordingly #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #171 +/- ##
=======================================
Coverage 73.32% 73.32%
=======================================
Files 57 57
Lines 3040 3040
Branches 391 391
=======================================
Hits 2229 2229
Misses 660 660
Partials 151 151 Continue to review full report at Codecov.
|
nathanaelbosch
force-pushed
the
bugfix/pylint
branch
from
fd0834d to
8e4a3aa
Compare
nathanaelbosch
force-pushed
the
bugfix/pylint
branch
from
8e4a3aa to
5c49412
Compare
|
It looks good to me, but I am not sure if I am the right person to review this... |
|
I just took you since I saw that you were already involved in this issue today^^ But okay, I'll ping @JonathanWenger for approval |
JonathanWenger
approved these changes
Aug 25, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #170. To make the CI tests pass again, I also added an additional exception for "raise-missing-from" to
probnum.prob(see #159 for all).