Refactor diffeq #179
Merged
Refactor diffeq #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #179 +/- ##
==========================================
- Coverage 73.19% 73.18% -0.02%
==========================================
Files 58 58
Lines 3026 3024 -2
Branches 391 391
==========================================
- Hits 2215 2213 -2
Misses 660 660
Partials 151 151
Continue to review full report at Codecov.
|
Closed
Closed
nathanaelbosch
requested changes
Aug 26, 2020
nathanaelbosch
approved these changes
Aug 26, 2020
|
@pnkraemer Did you use admin privileges to merge this? Currently |
|
not that I know of, but in any case black did not complain about this PR. |
|
This could again be due to a new Black release. I'll fix it by pinning the version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
steprule is now an argument for solve(), not an attribute of the solver. This is the first step of the refactoring, but independent enough that it can be merged independently.