[PLS Refactor] ProbabilisticLinearSolverState, LinearSystemBelief and LinearSolverPolicy
#460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to linsolve-policy
JonathanWenger
changed the title
LinearSolverState, LinearSystemBelief and LinearSolverPolicyLinearSolverState, LinearSystemBelief and ProbabilisticLinearSolverPolicy
JonathanWenger
changed the title
LinearSolverState, LinearSystemBelief and ProbabilisticLinearSolverPolicyProbabilisticLinearSolverState, LinearSystemBelief and LinearSolverPolicy
Closed
marvinpfoertner
approved these changes
Jul 13, 2021
| @property | ||
| def residuals(self) -> Tuple[np.ndarray, ...]: | ||
| r"""Residuals :math:`\{Ax_i - b\}_i`.""" | ||
| return tuple(self._residuals) |
There was a problem hiding this comment.
This might be nasty for an outside user, since it is not really transparent when the residuals are None and when they are np.ndarray.
I think it's fine for now though.
src/probnum/problems/_problems.py
Outdated
| @@ -194,6 +194,26 @@ class LinearSystem: | |||
| # For testing and benchmarking | |||
| solution: Optional[Union[np.ndarray, randvars.RandomVariable]] = None | |||
|
|
|||
| @classmethod | |||
| def from_matrix( | |||
There was a problem hiding this comment.
I think I would prefer the random_linear_system, but don't feel obliged to change things if this causes inconvenience.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a Nutshell
First components for the new compositional structure of the
ProbabilisticLinearSolver. Will be followed up with more PRs adding the remaining components.Detailed Description
This PR begins the refactoring of the probabilistic linear solver into a compositional pattern and adds the following component classes:
LinearSystemBeliefProbabilisticLinearSolverStateLinearSolverPolicy, incl. sub-classes implementing a random and deterministic policyIt also restructures the
probnum.linalgAPI reference into a more understandable hierarchy in line with the module and semantic structure.Note that this PR leaves the original implementation intact until all components of the new solver are included.
Related Issues
First part of #51 and supersedes part of #283.