-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LinOp arithmetic part 1 #505
LinOp arithmetic part 1 #505
Conversation
Codecov Report
@@ Coverage Diff @@
## main #505 +/- ##
==========================================
+ Coverage 88.49% 89.06% +0.57%
==========================================
Files 175 176 +1
Lines 6301 6612 +311
Branches 805 881 +76
==========================================
+ Hits 5576 5889 +313
+ Misses 501 485 -16
- Partials 224 238 +14
|
877c19e
to
7fd67ab
Compare
d543e01
to
6a7a78e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Let's discuss some details on monday.
Since we have Zeros
now, could you also add the
...
elif self._scalar == 0:
...
case in the constructor of Scaling
?
6a7a78e
to
a6542fb
Compare
The PR can't be merged because patch coverage is slightly too low. |
In a Nutshell
Add (efficient) arithmetics for combinations of Linear Operators : Part 1
Detailed Description
For some combinations of linear operators, there exist known arithmetics that can be implemented more efficiently.
E.g.
Kronecker @ Kronecker ~~> Kronecker
instead of yielding aProductLinearOperator
that builds up large call stacks.Related Issues
#509 ; mitigates the described problem in parts. (Subsequent PRs will consecutively solve the issue)